Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.20.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.21.0
Choose a head ref
  • 7 commits
  • 11 files changed
  • 7 contributors

Commits on Jan 8, 2024

  1. quic: avoid deadlock in Endpoint.Close

    Don't hold Endpoint.connsMu while calling Conn methods that can
    indirectly depend on acquiring it.
    
    Also change test cleanup to not wait for connections to drain
    when closing a test Endpoint, removing an unnecessary 0.1s delay
    in test runtime.
    
    Fixes golang/go#64982.
    
    Change-Id: If336e63b0a7f5b8d2ef63986d36f9ee38a92c477
    Reviewed-on: https://go-review.googlesource.com/c/net/+/554695
    Reviewed-by: Jonathan Amsterdam <jba@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    neild committed Jan 8, 2024
    1 Configuration menu
    Copy the full SHA
    26b646e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. http2: remove suspicious uint32->v conversion in frame code

    Function maxHeaderStringLen(...) uses uint32(int(v)) == v check to validate
    if length will fit in the int type.
    This check is a no-op on any architecture because int type always has at
    least 32 bits, so we can potentially encounter negative return values from
    maxHeaderStringLen(...) function. This can be bad as this outcome clearly
    breaks code intention and maybe some further code invariants.
    
    This patch replaces uint32(int(v)) == v check with more robust and simpler
    int(v) > 0 validation which is correct for our case when we operating with
    uint32
    
    Fixes golang/go#64961
    
    Change-Id: I31f95709df9d25593ade3200696ac5cef9f88652
    Reviewed-on: https://go-review.googlesource.com/c/net/+/554235
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Damien Neil <dneil@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    sivukhin authored and gopherbot committed Jan 10, 2024
    1 Configuration menu
    Copy the full SHA
    07e05fd View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. http2: avoid goroutine starvation in TestServer_Push_RejectAfterGoAway

    CL 557037 added a runtime.Gosched to prevent goroutine starvation
    in the wasm fake-net stack. Unfortunately, that Gosched causes the
    scheduler to enter a very similar starvation loop in this test.
    
    Add another runtime.Gosched to break this new loop.
    
    For golang/go#65178.
    
    Change-Id: I24b3f50dd728800462f71f27290b0d8f99d5ae5b
    Cq-Include-Trybots: luci.golang.try:x_net-gotip-wasip1-wasm_wasmtime,x_net-gotip-wasip1-wasm_wazero,x_net-gotip-js-wasm
    Reviewed-on: https://go-review.googlesource.com/c/net/+/557615
    Auto-Submit: Bryan Mills <bcmills@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Bryan C. Mills authored and gopherbot committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0d0b98c View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. internal/quic/qlog: fix typo

    VantageClient -> VantageServer
    
    Change-Id: Ie9738cffb06f03f961815853247e6f9cbe7fe466
    GitHub-Last-Rev: 5d440ad
    GitHub-Pull-Request: #202
    Reviewed-on: https://go-review.googlesource.com/c/net/+/555795
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    btwiuse authored and gopherbot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b2208d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. dns/dnsmessage: allow name compression for SRV resource parsing

    As per RFC 3597:
    
    Receiving servers MUST decompress domain names in RRs of well-known
       type, and SHOULD also decompress RRs of type RP, AFSDB, RT, SIG, PX,
       NXT, NAPTR, and SRV (although the current specification of the SRV RR
       in RFC2782 prohibits compression, RFC2052 mandated it, and some
       servers following that earlier specification are still in use).
    
    This change allows SRV resource decompression.
    
    Updates golang/go#36718
    Updates golang/go#37362
    
    Change-Id: I473c0d3803758e5b12886f378d2ed54bd5392144
    GitHub-Last-Rev: 88d2e06
    GitHub-Pull-Request: #199
    Reviewed-on: https://go-review.googlesource.com/c/net/+/540375
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Auto-Submit: Damien Neil <dneil@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    mateusz834 authored and gopherbot committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    73e4b50 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. html: fix SOLIDUS '/' handling in attribute parsing

    Calling the Tokenizer with HTML elements containing SOLIDUS (/) character
    in the attribute name results in incorrect tokenization.
    
    This is due to violation of the following rule transitions in the WHATWG spec:
    - https://html.spec.whatwg.org/multipage/parsing.html#attribute-name-state,
      where we are not reconsuming the character if '/' is encountered
    - https://html.spec.whatwg.org/multipage/parsing.html#after-attribute-name-state,
      where we are not switching to self closing state
    
    Fixes golang/go#63402
    
    Change-Id: I90d998dd8decde877bd63aa664f3657aa6161024
    GitHub-Last-Rev: 3546db8
    GitHub-Pull-Request: #195
    Reviewed-on: https://go-review.googlesource.com/c/net/+/533518
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    maciekmm authored and gopherbot committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    643fd16 View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I314af161ceac84fec04c729a71860ad35335513b
    Reviewed-on: https://go-review.googlesource.com/c/net/+/562495
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    gopherbot committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    73d21fd View commit details
    Browse the repository at this point in the history
Loading