Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.27.0
Choose a head ref
  • 3 commits
  • 6 files changed
  • 3 contributors

Commits on Jun 12, 2024

  1. http2: avoid Transport hang with Connection: close and AllowHTTP

    CL 111835 changed Transport stream ID numbering to start at
    stream 3 when AllowHTTP is set. This was based on a
    misunderstanding:
    
    When a connection upgrades an HTTP/1.1 request to HTTP/2,
    the initial HTTP/1.1 request occupies stream 1.
    However, Transport does not perform HTTP protocol upgrades.
    When using a Transport to send unencrypted HTTP/2 requests,
    the entire connection uses HTTP/2, the first request is
    sent as HTTP/2, and there is no reason not to use stream 1
    for this request.
    
    Starting from stream 3 is mostly harmless,
    but ClientConn.idleStateLocked assumes that client streams
    start from 1. This causes it to misidentify new single-use
    connections as having already sent a request (when AllowHTTP
    is set), and therefore not suitable for use.
    
    Revert to always starting stream IDs at 1.
    
    Fixes golang/go#67671
    
    Change-Id: I97c89de4ae49623d916f9dbd200f8252d2fd4247
    Reviewed-on: https://go-review.googlesource.com/c/net/+/591275
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Jonathan Amsterdam <jba@google.com>
    neild committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9617c63 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. quic: skip tests which depend on unimplemented UDP functions on Plan 9

    The ReadMsgUDP and WriteMsgUDP methods of UDPConn are not implemented
    (yet?) on Plan 9. Skip tests which require them.
    
    Fixes golang/go#68288
    
    Change-Id: Ic6c81b19322d589c10b16da61e9b89284294be05
    Reviewed-on: https://go-review.googlesource.com/c/net/+/596795
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    millerresearch authored and thanm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    77708f7 View commit details
    Browse the repository at this point in the history
  2. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ibb0ab46488252d035430a654eed5dd4caab7509e
    Reviewed-on: https://go-review.googlesource.com/c/net/+/596895
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    gopherbot committed Jul 5, 2024
    2 Configuration menu
    Copy the full SHA
    e2310ae View commit details
    Browse the repository at this point in the history
Loading