-
Notifications
You must be signed in to change notification settings - Fork 588
Comparing changes
Open a pull request
base repository: golang/sys
base: v0.32.0
head repository: golang/sys
compare: v0.33.0
- 5 commits
- 8 files changed
- 5 contributors
Commits on Apr 9, 2025
-
windows: fix dangling pointers in (*SECURITY_DESCRIPTOR).ToAbsolute
Prior to this CL, a byte slice was allocated via make to use as the absoluteSD argument passed to the Windows API MakeAbsoluteSD. MakeAbsoluteSD then sets pointers outside the view of the GC, including pointers within absoluteSD that point to other chunks of memory we pass into MakeAbsoluteSD. CL 653856 recently allowed more make results to be stack allocated, which worsened the problems here and made it easier for those pointers in absoluteSD to become dangling pointers, though the core problems here existed before. This CL instead allocates absoluteSD as a proper SECURITY_DESCRIPTOR struct so that the GC can be aware of its pointers. We also verify the pointers are as we expect, and then set them explicitly in view of the GC. Updates golang/go#73199 Change-Id: Id8038d38a887bb8ff3ffc6eae603589b97e92cdc Reviewed-on: https://go-review.googlesource.com/c/sys/+/663355 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
Configuration menu - View commit details
-
Copy full SHA for 6a85559 - Browse repository at this point
Copy the full SHA 6a85559View commit details
Commits on Apr 22, 2025
-
windows: fix slicing of NTUnicodeString values
We were slicing using a count of bytes, not a count of uint16s. Fixes golang/go#73460 Change-Id: If0fd19e795078c01fda5b976e3c34af115b25dcc Reviewed-on: https://go-review.googlesource.com/c/sys/+/667235 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Quim Muntal <quimmuntal@gmail.com> Auto-Submit: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@google.com>
Configuration menu - View commit details
-
Copy full SHA for 7138967 - Browse repository at this point
Copy the full SHA 7138967View commit details -
windows: add virtual key codes and console input consts
This adds console input related key codes and consts Change-Id: I8ebd76995a2c9ddd150cf04890a9e5053841fcab GitHub-Last-Rev: 8e534f4 GitHub-Pull-Request: #226 Reviewed-on: https://go-review.googlesource.com/c/sys/+/621495 Reviewed-by: Junyang Shao <shaojunyang@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Configuration menu - View commit details
-
Copy full SHA for 8e9e046 - Browse repository at this point
Copy the full SHA 8e9e046View commit details
Commits on May 1, 2025
-
cpu: add crypto extensions detection for riscv64
This CL adds RISC-V cryptography extensions detection. Direct detection of the extensions zvkned, zvknhb, zvksed and zvksh is not supported, since the crypto spec requires these extensions implemented with data independent timing (zkt). However, their presence may be inferred by checking for the shorthand extensions: zvkn, zvknc, zvkng, zvks, zvksc, zvksg. Change-Id: Ic00038cebf1b9f77426876b06b08f206473ad6fb Reviewed-on: https://go-review.googlesource.com/c/sys/+/664375 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Mark Ryan <markdryan@rivosinc.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Pengcheng Wang <wangpengcheng.pp@bytedance.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Configuration menu - View commit details
-
Copy full SHA for c0a9559 - Browse repository at this point
Copy the full SHA c0a9559View commit details
Commits on May 2, 2025
-
windows: add WSADuplicateSocket
WSADuplicateSocket is useful to pass sockets between processes on Windows. For golang/go#10350. Change-Id: I6563184fe4d4477d402a6af81b254bd8aa992d2e Reviewed-on: https://go-review.googlesource.com/c/sys/+/668215 Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Carlos Amedee <carlos@golang.org>
Configuration menu - View commit details
-
Copy full SHA for 3d9a6b8 - Browse repository at this point
Copy the full SHA 3d9a6b8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.32.0...v0.33.0