Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.17.0
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.18.0
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Aug 20, 2024

  1. all: rename Example test functions to prevent vet errors 

    Building x/text was being prevented by vet errors caused by Example
test functions of the form ExampleXxx where Xxx was not an identifier
declared in the package. This is corrected by renaming:
  ExampleCollator_Strings to ExampleCollator_strings in text/collate
  ExampleDecodeWindows1252 to Example_decodeWindows1252 in text/encoding
  ExampleSelect to ExampleSelectf in text/feature/plural

Fixes golang/go#68967

Change-Id: Id584a518af766676ab44fc49c12160e36f66542a
Reviewed-on: https://go-review.googlesource.com/c/text/+/606736
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
    @millerresearch @gopherbot
    millerresearch authored and gopherbot committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1e3e9fd View commit details
    Browse the repository at this point in the history
Loading