Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/time
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.0
Choose a base ref
...
head repository: golang/time
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.10.0
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Nov 2, 2024

  1. README: don't recommend go get

    These days people will just import the packages and the go tool will
    do the right thing. We don't need to explain it.
    
    Add a pointer to the git repo, though.
    
    For golang/go#62645
    
    Change-Id: I87fbf5d50e75120052f56ed6d4ac9977056cde9f
    Reviewed-on: https://go-review.googlesource.com/c/time/+/624235
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    ianlancetaylor authored and gopherbot committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    3846194 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2025

  1. rate: make function comment match function name

    Change-Id: I603ca855eac736e90d2ba2bb7ce61981a4a91918
    Reviewed-on: https://go-review.googlesource.com/c/time/+/638776
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    cuishuang authored and gopherbot committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    1ce61fe View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2025

  1. rate: prevent overflows when calculating durationFromTokens

    Currently, there is a conversion from float64 to int64 when returning the duration needed to accumulate the required number of tokens.
    When limiters are set with low limits, i.e. 1e-10, the duration needed is greater than math.MaxInt64.
    As per the language specifications, in these scenarios the outcome is implementation determined.
    This results in overflows on `amd64`, resulting in no wait, effectively jamming the limiter open.
    
    Here we add a check for this scenario, returning InfDuration if the desired duration is greater than math.MaxInt64.
    
    Fixes golang/go#71154
    
    Change-Id: I775aab80fcc8563a59aa399844a64ef70b9eb76a
    Reviewed-on: https://go-review.googlesource.com/c/time/+/641336
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    tomcoupland authored and gopherbot committed Jan 8, 2025
    Configuration menu
    Copy the full SHA
    2c6c5a2 View commit details
    Browse the repository at this point in the history
Loading