fix: Parse boolean in slice for gitauth (coder#5113)

kylecarbs · web-flow · commit 60cec022eb3c · 2022-11-17T07:52:11.000-06:00
This was causing a panic for the new `no_refesh` option!
diff --git a/cli/deployment/config.go b/cli/deployment/config.go
@@ -529,9 +529,11 @@ func readSliceFromViper[T any](vip *viper.Viper, key string, value any) []T {
 				newType := reflect.Indirect(reflect.New(elementType))
 				instance = &newType
 			}
-			switch instance.Field(i).Type().String() {
+			switch v := instance.Field(i).Type().String(); v {
 			case "[]string":
 				value = vip.GetStringSlice(configKey)
+			case "bool":
+				value = vip.GetBool(configKey)
 			default:
 			}
 			instance.Field(i).Set(reflect.ValueOf(value))
diff --git a/cli/deployment/config_test.go b/cli/deployment/config_test.go
@@ -167,6 +167,7 @@ func TestConfig(t *testing.T) {
 			"CODER_GITAUTH_0_TOKEN_URL":     "https://token.com",
 			"CODER_GITAUTH_0_REGEX":         "github.com",
 			"CODER_GITAUTH_0_SCOPES":        "read write",
+			"CODER_GITAUTH_0_NO_REFRESH":    "true",
 
 			"CODER_GITAUTH_1_ID":            "another",
 			"CODER_GITAUTH_1_TYPE":          "gitlab",
@@ -187,6 +188,7 @@ func TestConfig(t *testing.T) {
 				TokenURL:     "https://token.com",
 				Regex:        "github.com",
 				Scopes:       []string{"read", "write"},
+				NoRefresh:    true,
 			}, {
 				ID:           "another",
 				Type:         "gitlab",

Original file line number	Diff line number	Diff line change
`@@ -529,9 +529,11 @@ func readSliceFromViper[T any](vip *viper.Viper, key string, value any) []T {`
`529`	`529`	`newType := reflect.Indirect(reflect.New(elementType))`
`530`	`530`	`instance = &newType`
`531`	`531`	`}`
`532`		`- switch instance.Field(i).Type().String() {`
	`532`	`+ switch v := instance.Field(i).Type().String(); v {`
`533`	`533`	`case "[]string":`
`534`	`534`	`value = vip.GetStringSlice(configKey)`
	`535`	`+ case "bool":`
	`536`	`+ value = vip.GetBool(configKey)`
`535`	`537`	`default:`
`536`	`538`	`}`
`537`	`539`	`instance.Field(i).Set(reflect.ValueOf(value))`