Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/google-java-format
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.24.0
Choose a base ref
...
head repository: google/google-java-format
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.25.0
Choose a head ref
  • 19 commits
  • 33 files changed
  • 3 contributors

Commits on Oct 4, 2024

  1. Update the IntelliJ plugin to 1.24.0.

    PiperOrigin-RevId: 682389166
    plumpy authored and google-java-format Team committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4340416 View commit details
    Browse the repository at this point in the history
  2. Remove JDK 11 from CI

    also use 21 for snapshot builds, see #1015
    cushon authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6c43670 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Update google-java-format to build with Java 17

    #1159
    
    PiperOrigin-RevId: 682509011
    cushon authored and google-java-format Team committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a3737d9 View commit details
    Browse the repository at this point in the history
  2. Update Error Prone version to 2.32.0

    Startblock:
      * unknown commit is submitted
    PiperOrigin-RevId: 682513849
    cushon authored and google-java-format Team committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0984312 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Update Error Prone version to 2.34.0

    And pass `--should-stop=ifError=FLOW`, see https://github.com/google/error-prone/releases/tag/v2.34.0
    
    PiperOrigin-RevId: 687476556
    cushon authored and google-java-format Team committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    6586afe View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Place the trailing """ of a text block to appear on its own line

    PiperOrigin-RevId: 690618067
    cushon authored and google-java-format Team committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    00cce7b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Add an integration test for comments before text blocks

    PiperOrigin-RevId: 694499404
    cushon authored and google-java-format Team committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    666fe33 View commit details
    Browse the repository at this point in the history
  2. If a text block is outdented, outdent the opening """ too

    PiperOrigin-RevId: 694533649
    cushon authored and google-java-format Team committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    98c6bbd View commit details
    Browse the repository at this point in the history
  3. Always break between leading comments and opening delimiters of text …

    …blocks
    
    PiperOrigin-RevId: 694550141
    cushon authored and google-java-format Team committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    81e9e1c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Fix an off-by-one bug with column limit handling for text blocks

    PiperOrigin-RevId: 695348215
    cushon authored and google-java-format Team committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d4b3f0d View commit details
    Browse the repository at this point in the history
  2. More text block test cases

    PiperOrigin-RevId: 695356983
    cushon authored and google-java-format Team committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fc31690 View commit details
    Browse the repository at this point in the history
  3. Back out text block special cases

    PiperOrigin-RevId: 695363436
    cushon authored and google-java-format Team committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    02b6ad1 View commit details
    Browse the repository at this point in the history
  4. Explicitly test that reformatting after formatting and string wrappin…

    …g is idempotent
    
    There's some indirect coverage of this from line ending tests, but they don't exercise string wrapping.
    
    PiperOrigin-RevId: 695382884
    cushon authored and google-java-format Team committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    beacc08 View commit details
    Browse the repository at this point in the history
  5. Reformat the formatter

    To avoid spurious diffs during other development.
    
    PiperOrigin-RevId: 695452895
    cushon authored and google-java-format Team committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e35f60e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Add some more test cases for pattern guards

    PiperOrigin-RevId: 695910986
    cushon authored and google-java-format Team committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    453ad08 View commit details
    Browse the repository at this point in the history
  2. Allow breaks before pattern guards

    Previously there were never breaks before `when` pattern guards, which produced surprising results.
    
    There's possible future work here around evaluating how many level of continuation indents to take to differentiate between syntactic levels, but I think this is an improvement on the status quo.
    
    PiperOrigin-RevId: 696193971
    cushon authored and google-java-format Team committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7e5fb80 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Remove Java17InputAstVisitor

    JDk 17 is now the lowest supported version.
    
    #1159
    
    PiperOrigin-RevId: 697756606
    cushon authored and google-java-format Team committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3356bd3 View commit details
    Browse the repository at this point in the history
  2. Fix logic for checking if text blocks are already deindented

    Check the last line instead of the first line of the text block contents. Empty lines in the text block have no leading whitespace but do not indicate the contents are deindented, only non-empty lines should be considered. The last line will never be empty, it contains at least the close delimiter.
    
    PiperOrigin-RevId: 697785256
    cushon authored and google-java-format Team committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5269625 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    bd33662 View commit details
    Browse the repository at this point in the history
Loading