Fix China fix making region required #496
Conversation
|
Thanks for this! Please merge ASAP because the current release breaks on the region being undefined. |
|
@itsmichaeldiego Please merge this, as the current release is not working. |
|
can someone please explain how is this working or if there is any proper documentation. It seems it's not woking doing what it says on the readme :( |
|
@Aldoso What problems do you experience? The only thing this PR (together with #494) does is making the lib use the China API URL if setting bootstrapURLKeys.region to 'cn'. If not setting 'cn' there should be no difference to version 0.27.0 (the version prior to these two PRs). This is explained here in the docs. However, a bug made version 0.28.0 break if not specifying a region at all. This is no longer a problem in 0.29.0. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Bah, sorry for stupid misstake. My PR (#494) to fix (#493) made the code break if not specifying bootstrapURLKeys.region. Sorry, here is a fix for that.