Skip to content

fix error about fromLatLngToDivPixel #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2018

Conversation

fmy
Copy link
Contributor

@fmy fmy commented Feb 19, 2018

fix "Cannot read property 'fromLatLngToDivPixel' of undefined" #257

In my production, errors occurred in the idle event handler, not in the draw() function.

I can not find the condition, but I can reproduce this error in local env.
It looks like below.

2018-02-19 19 56 31

fix "Cannot read property 'fromLatLngToDivPixel' of undefined" google-map-react#257
@jeremymarc
Copy link

+1

1 similar comment
@Stosiu
Copy link

Stosiu commented Feb 22, 2018

+1

@loris
Copy link

loris commented Feb 22, 2018

+1, same error happening in production

Copy link
Member

@itsmichaeldiego itsmichaeldiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change but we need to keep in mind that there are some binding events under your return; that might get broken, so we should skip only the code that relates to div or overlay

@fmy
Copy link
Contributor Author

fmy commented Feb 23, 2018

@itsmichaeldiego I addressed your point. please review it!

Copy link
Member

@itsmichaeldiego itsmichaeldiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@itsmichaeldiego itsmichaeldiego merged commit 4a07176 into google-map-react:master Feb 23, 2018
@itsmichaeldiego
Copy link
Member

@fmy @loris @Stosiu @jeremymarc Merged and published in version 0.32.0.

@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants