Skip to content

upgrade .babelrc #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2018
Merged

upgrade .babelrc #521

merged 3 commits into from
Mar 10, 2018

Conversation

alirezavalizade
Copy link
Contributor

@alirezavalizade alirezavalizade commented Mar 3, 2018

fix warning on installing packages (🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!)

@itsmichaeldiego
Copy link
Member

itsmichaeldiego commented Mar 6, 2018

@alirezavalizade Please provide description and fix the build

@alirezavalizade
Copy link
Contributor Author

@itsmichaeldiego what does mean fix the build ?

@itsmichaeldiego
Copy link
Member

@alirezavalizade If you take a look at Github, at the bottom, it says All checks have failed, the details are here: https://travis-ci.org/istarkov/google-map-react/builds/348708068?utm_source=github_status&utm_medium=notification

@alirezavalizade
Copy link
Contributor Author

@itsmichaeldiego Thank you! 👍

Copy link
Member

@itsmichaeldiego itsmichaeldiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, thanks for this. I left one comment, but besides that it looks good.

.babelrc Outdated
"loose": true
}], "react", "stage-0"
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the same format we had before? I think this format is less readable.

Also, we want an empty line at the end of the file, GitHub is warning us here:
screen shot 2018-03-10 at 9 20 08 am

Fix format.
@itsmichaeldiego itsmichaeldiego merged commit 32d95ab into google-map-react:master Mar 10, 2018
@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants