Skip to content

Use React 16 portal to render map overlay #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2018
Merged

Use React 16 portal to render map overlay #643

merged 2 commits into from
Sep 20, 2018

Conversation

clayne11
Copy link
Contributor

This allows the new context API to propagate context properly.

Fixes #642.

@clayne11
Use React 16 portal to render map overlay
85b4dd5 
This allows the new context API to propagate context properly.
itsmichaeldiego
itsmichaeldiego reviewed Sep 20, 2018
View reviewed changes
@clayne11
Copy link
Contributor Author

Done.

@itsmichaeldiego itsmichaeldiego merged commit b121bb6 into google-map-react:master Sep 20, 2018
This was referenced Sep 20, 2018
Merged
Closed
@stuartherring
Copy link

This change breaks the component when used with React versions prior to 16.

@abumq
Copy link

abumq commented Sep 21, 2018

This should have been part of a major release then it would have been fine. So 1.0.6 is not broken but 1.0.7 is broken. (Complains about createPortal which is part of 16)

itsmichaeldiego added a commit that referenced this pull request Sep 21, 2018
@itsmichaeldiego
Revert "Use React 16 portal to render map overlay (#643)"
5cad6bf 
This reverts commit b121bb6.
@itsmichaeldiego itsmichaeldiego mentioned this pull request Sep 21, 2018
Merged
itsmichaeldiego added a commit that referenced this pull request Sep 21, 2018
@itsmichaeldiego
Revert 643 fix/map context (#645)
317b5c0 
* Revert "Bump version to 1.0.7 (#644)"

This reverts commit 800092a.

* Revert "Add passive scroll (#631)"

This reverts commit 40c8f67.

* Revert "Use React 16 portal to render map overlay (#643)"

This reverts commit b121bb6.
@itsmichaeldiego
Copy link
Member

@stuartherring @abumusamq Sorry for the inconvenience! This was totally my bad, I just fixed this and released in 1.0.8.

@clayne11 do you mind opening the PR again? We will add this to the next major release.

Or, I think there should be a way to identify if the user has React 16 or not and use createPortal if so, but that would be a bit more tricky.

@clayne11
Copy link
Contributor Author

No problem I can do that. Are you planning to cut a new major release with this soon? React 16 has been out for a year now (released Sept 26, 2017) so I think it's about time to move forward.

@itsmichaeldiego
Copy link
Member

@clayne11 Yes, we would like to do that soon but lately it has been only me taking care of the library, any help would be accepted lovely xD.

DonovanDeSmedt added a commit to DonovanDeSmedt/google-map-react that referenced this pull request Nov 21, 2018
@DonovanDeSmedt
Merge branch 'master' of github.com:google-map-react/google-map-react
ad9e522 
* 'master' of github.com:google-map-react/google-map-react:
  Bump to 1.1.1 (google-map-react#680)
  Revert "Added feature: update heat map on data change + fix linting" (google-map-react#679)
  Bump version to 1.1.0 (google-map-react#671)
  Added feature: update heat map on data change + fix linting (google-map-react#593)
  Pass map instance to onDrag handler (google-map-react#656)
  add math abs to avoid negative values when calculating zoom (google-map-react#655)
  Bump version to 1.0.9 (google-map-react#651)
  Custom div style options (google-map-react#634)
  Bump version to 1.0.8 (google-map-react#646)
  Revert 643 fix/map context (google-map-react#645)
  Bump version to 1.0.7 (google-map-react#644)
  Add passive scroll (google-map-react#631)
  Use React 16 portal to render map overlay (google-map-react#643)
  Fix old examples links and add one to new examples (google-map-react#633)
  Bump version to 1.0.6 (google-map-react#621)
  Add prop `onTilesLoaded` (google-map-react#615)
  Fix typo, and call fromContainerPixelToLatLng() as you would expect. (google-map-react#620)
  Update API.md (google-map-react#611)
  Upgrade version to 1.0.5 (google-map-react#607)
  Remove marker jiggle. (google-map-react#603)
@lock
Copy link

lock bot commented Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@itsmichaeldiego itsmichaeldiego itsmichaeldiego left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context (new API) is not propagated to google-map-react children
4 participants
@clayne11 @stuartherring @abumq @itsmichaeldiego