Skip to content

[py] GRPC routing metadata is incorrectly computed for update calls #364

Closed
@bdhess

Description

@bdhess

As an example:
https://github.com/googleapis/google-cloud-python/blob/de73e45a7183a638113153d0faec105cfc437f0e/kms/google/cloud/kms_v1/gapic/key_management_service_client.py#L1569

When the crypto_key argument to UpdateCryptoKey is a dict, the attempt to resolve crypto_key.name results in an AttributeError ("'dict' object has no attribute 'name'"). The error is caught and ignored, so this fails silently.

Reported by a customer at https://stackoverflow.com/questions/59617920/cant-update-cryptokey-in-us-central1

Metadata

Metadata

Assignees

Labels

type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions