Skip to content

Conversation

nbayati
Copy link
Contributor

@nbayati nbayati commented Aug 6, 2025

No description provided.

@nbayati nbayati requested review from a team as code owners August 6, 2025 22:27
@nbayati nbayati assigned nbayati and unassigned nbayati Aug 6, 2025
@nbayati nbayati requested a review from lsirac August 6, 2025 22:27
@nbayati nbayati changed the title docs: update README to include x509 feature. docs: update user guide to include x509 feature. Aug 6, 2025
@nbayati nbayati requested a review from sai-sunder-s August 6, 2025 23:41

Where the following variables need to be substituted:

* ``$PROJECT_NUMBER``: The Google Cloud project number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this project id or project number? They are different things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great point. It should be the project number. I've updated the text to " The unique, numerical identifier for your Google Cloud project. This is not the Project ID string." to make it more clear.

@nbayati nbayati requested a review from sai-sunder-s August 7, 2025 16:59
@nbayati nbayati enabled auto-merge (squash) August 12, 2025 16:35
@nbayati nbayati added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2025
@nbayati nbayati merged commit 2d89ab4 into googleapis:main Aug 12, 2025
13 checks passed
@nbayati nbayati deleted the docs/update-readme-x509 branch August 12, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants