feat: add request response logging to auth #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add functionality to hash data * change sensitive fields to private * update to sha512 * update docstring
* chore: add request-response log helpers * fix presubmit
* feat: opt-in logging support for request/response * add pragma no cover * add test coverage for request/response * add code coverage
* chore: remove logging for async requests * change Dict to Mapping * fix mypy and lint issues * address PR feedback * link issue
* feat: parse request/response for logging * add test case for list * address PR comments * address PR feedback * fix typo * add test coverage * add code coverage
* feat: hash sensitive info in logs * make helper private * add code coverage * address PR feedback * fix mypy type issue
* feat: add support for async response log * fix whitespace * add await * add code coverage * fix lint * fix lint issues * address PR feedback * address PR feedback * link issue
parthea
approved these changes
Apr 11, 2025
* fix: remove dep on api-core for logging * disable propagation to the root logger * update async helpers tests * fix lint issue
sai-sunder-s
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging support to the auth library.