Skip to content

fix: add impersonated SA via local ADC support for fetch_id_token #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2025
Merged

fix: add impersonated SA via local ADC support for fetch_id_token #1740

merged 5 commits into from
Apr 10, 2025

Conversation

nolanleastin
Copy link
Contributor

fetch_id_token was only supported for service accounts and fetch ID token from metadata server if it exists.

This PR adds support for impersonated service accounts.

@nolanleastin nolanleastin requested review from a team as code owners April 8, 2025 22:01
@nolanleastin nolanleastin self-assigned this Apr 8, 2025
@nolanleastin nolanleastin force-pushed the neastin/id-token-impersonated-sa branch 2 times, most recently from 95efd68 to ce4845b Compare April 10, 2025 19:45
@nolanleastin nolanleastin force-pushed the neastin/id-token-impersonated-sa branch from ce4845b to 13ffc87 Compare April 10, 2025 20:17
@nolanleastin nolanleastin merged commit f249764 into main Apr 10, 2025
16 checks passed
@nolanleastin nolanleastin deleted the neastin/id-token-impersonated-sa branch April 10, 2025 20:44
@release-please release-please bot mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

Assignees

@nolanleastin nolanleastin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolanleastin @sai-sunder-s