Skip to content

Conversation

loeng2023
Copy link
Contributor

@loeng2023 loeng2023 commented Feb 12, 2024

Add document saver class and support save/load/delete user journeys.

In detail:

  • Load documents via default table
  • Load documents via custom table/metadata
  • Load documents via custom page content columns
  • Load documents via custom metadata columns
  • Initialize MySQLDocumentSaver with existing table
  • Initialize custom MySQLDocumentSaver table & add documents with metadata
  • Delete documents

The difference between MSSQL doc loader/saver to MySQL doc loader/saver is:
Because MSSQL doesn't have built-in JSON field, we only do JSON loads/dumps for default metadata field. For MySQL, we do JSON loads/dumps for all fields with field_type JSON.

@loeng2023 loeng2023 requested a review from a team as a code owner February 12, 2024 21:16
@product-auto-label product-auto-label bot added the api: cloudsql-sqlserver Issues related to the googleapis/langchain-google-cloud-sql-mssql-python API. label Feb 12, 2024
Copy link
Contributor

@totoleon totoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loeng2023 loeng2023 merged commit b90a9bb into main Feb 13, 2024
@loeng2023 loeng2023 deleted the doc-loader branch February 13, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql-sqlserver Issues related to the googleapis/langchain-google-cloud-sql-mssql-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants