From 72a2df1402195cba69187dda1b9b6c3c0f0bc82e Mon Sep 17 00:00:00 2001 From: jackwotherspoon Date: Fri, 20 Sep 2024 12:36:57 +0000 Subject: [PATCH] feat: remove support for Python 3.8 --- .github/sync-repo-settings.yaml | 1 - DEVELOPER.md | 8 ++++---- README.rst | 2 +- integration.cloudbuild.yaml | 11 +++++++++-- pyproject.toml | 3 +-- 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml index 53b659b..a2e53e6 100644 --- a/.github/sync-repo-settings.yaml +++ b/.github/sync-repo-settings.yaml @@ -27,7 +27,6 @@ branchProtectionRules: requiredStatusCheckContexts: - "cla/google" - "lint" - - "mssql-integration-test-pr-py38 (langchain-cloud-sql-testing)" - "mssql-integration-test-pr-py39 (langchain-cloud-sql-testing)" - "mssql-integration-test-pr-py310 (langchain-cloud-sql-testing)" - "mssql-integration-test-pr-py311 (langchain-cloud-sql-testing)" diff --git a/DEVELOPER.md b/DEVELOPER.md index c1d95df..62cac1a 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -34,11 +34,11 @@ These tests are registered as required tests in `.github/sync-repo-settings.yaml #### Trigger Setup -Cloud Build triggers (for Python versions 3.8 to 3.11) were created with the following specs: +Cloud Build triggers (for Python versions 3.9 to 3.11) were created with the following specs: ```YAML -name: mssql-integration-test-pr-py38 -description: Run integration tests on PR for Python 3.8 +name: mssql-integration-test-pr-py39 +description: Run integration tests on PR for Python 3.9 filename: integration.cloudbuild.yaml github: name: langchain-google-cloud-sql-mssql-python @@ -55,7 +55,7 @@ substitutions: _INSTANCE_ID: _DB_NAME: _REGION: us-central1 - _VERSION: "3.8" + _VERSION: "3.9" ``` Use `gcloud builds triggers import --source=trigger.yaml` to create triggers via the command line diff --git a/README.rst b/README.rst index 526c5dd..5fc032f 100644 --- a/README.rst +++ b/README.rst @@ -44,7 +44,7 @@ With `virtualenv`_, it’s possible to install this library without needing syst Supported Python Versions ^^^^^^^^^^^^^^^^^^^^^^^^^ -Python >= 3.8 +Python >= 3.9 Mac/Linux ^^^^^^^^^ diff --git a/integration.cloudbuild.yaml b/integration.cloudbuild.yaml index a46e34d..c2ce04d 100644 --- a/integration.cloudbuild.yaml +++ b/integration.cloudbuild.yaml @@ -26,7 +26,14 @@ steps: - id: Run integration tests name: python:${_VERSION} entrypoint: python - args: ["-m", "pytest", "--cov=langchain_google_cloud_sql_mssql", "--cov-config=.coveragerc", "tests/"] + args: + [ + "-m", + "pytest", + "--cov=langchain_google_cloud_sql_mssql", + "--cov-config=.coveragerc", + "tests/", + ] env: - "PROJECT_ID=$PROJECT_ID" - "INSTANCE_ID=$_INSTANCE_ID" @@ -46,7 +53,7 @@ substitutions: _INSTANCE_ID: test-mssql-instance _REGION: us-central1 _DB_NAME: test - _VERSION: "3.8" + _VERSION: "3.9" options: dynamicSubstitutions: true diff --git a/pyproject.toml b/pyproject.toml index 865537f..46f73fa 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ dynamic = ["version"] description = "LangChain integrations for Google Cloud SQL for SQL Server" readme = "README.rst" license = {file = "LICENSE"} -requires-python = ">=3.8" +requires-python = ">=3.9" authors = [ {name = "Google LLC", email = "googleapis-packages@google.com"} ] @@ -20,7 +20,6 @@ classifiers = [ "License :: OSI Approved :: Apache Software License", "Programming Language :: Python", "Programming Language :: Python :: 3", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11",