Skip to content

fix: remove unused enum at document_converter #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

JU-2094
Copy link
Member

@JU-2094 JU-2094 commented Mar 5, 2024

Fix #23

Remove unused code.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #23

Fix #23

Remove unused code.
@JU-2094 JU-2094 requested a review from a team as a code owner March 5, 2024 18:17
Copy link

conventional-commit-lint-gcf bot commented Mar 5, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/langchain-google-datastore-python API. label Mar 5, 2024
@JU-2094 JU-2094 changed the title fix: Remove unused enum at document_converter fix: remove unused enum at document_converter Mar 5, 2024
@JU-2094 JU-2094 merged commit a3b7b2f into main Mar 5, 2024
@JU-2094 JU-2094 deleted the JU-2094-issue-23 branch March 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/langchain-google-datastore-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

langchain-google-datastore-python fails with python3.10
2 participants