Skip to content

chore: add repo files #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2024
Merged

chore: add repo files #12

merged 2 commits into from
Dec 2, 2024

Conversation

averikitsch
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Follow the Samples Style Guide
  • Ensure the tests and linter pass
  • Communicate test infrastructure changes, i.e. API enablement, secrets
  • Appropriate docs were updated (if necessary)

🛠️ Fixes #<issue_number_goes_here>

@averikitsch averikitsch requested a review from a team as a code owner November 29, 2024 19:45
@vishwarajanand vishwarajanand mentioned this pull request Dec 2, 2024
Merged
vishwarajanand
vishwarajanand approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The tests were fixed as part of PR#13, I rebased it here after merging to main and tests are green here. So merging this PR to unblock others.

@vishwarajanand vishwarajanand merged commit e7a4046 into main Dec 2, 2024
9 checks passed
@vishwarajanand vishwarajanand deleted the repo-files branch December 2, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averikitsch @vishwarajanand