Skip to content

feat: add iterator capability to paged iterators #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2021
Merged

feat: add iterator capability to paged iterators #200

merged 2 commits into from
Jun 8, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 7, 2021

Closes #175.

This PR transforms *Iterator classes to actual iterators (before they were just iterables).

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

plamut added 2 commits June 7, 2021 13:16
@plamut
feat: add iterator capability to *Iterator classes
77ce6b3 
The *Iterator classes are only _iterables_, and this commit also makes
them _iterators_, i.e. calling next(iterator) on them now works.
@plamut
Make AsyncIterator an actual async iterator
ade1f11
@plamut plamut requested a review from tswast June 7, 2021 12:49
@plamut plamut requested a review from a team as a code owner June 7, 2021 12:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2021
@plamut plamut merged commit 3487d68 into googleapis:master Jun 8, 2021
@plamut plamut deleted the iss-175 branch June 8, 2021 08:30
This was referenced May 30, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

paged iterators are not iterators
2 participants
@plamut @tseaver