Skip to content

proto-plus >= 1.25 needed for python 3.13 #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea opened this issue Oct 19, 2024 · 0 comments · Fixed by #740
Closed

proto-plus >= 1.25 needed for python 3.13 #737

parthea opened this issue Oct 19, 2024 · 0 comments · Fixed by #740
Assignees
@parthea
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Collaborator

parthea commented Oct 19, 2024

The setup.py file should be updated to require proto-plus >= 1.25 for python_version >=3.13 due to googleapis/proto-plus-python#490

See release notes here: https://github.com/googleapis/proto-plus-python/releases/tag/v1.25.0

Add "proto-plus >= 1.25.0, <2.0.0dev; python_version>='3.13'", after the following line

python-api-core/setup.py

Line 34 in 46b3d3a

"proto-plus >= 1.22.3, <2.0.0dev",

@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 19, 2024
@parthea parthea self-assigned this Oct 19, 2024
@parthea parthea changed the title proto-plus >= 1.25 proto-plus >= 1.25 needed for python 3.13 Oct 19, 2024
This was referenced Oct 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: require proto-plus >= 1.25.0 for Python 3.13 googleapis/python-api-core
1 participant
@parthea