Skip to content

feat!: drop support for locational endpoints #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 28, 2025
Merged

feat!: drop support for locational endpoints #1542

merged 13 commits into from
Mar 28, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 25, 2025 •
edited
Loading

BREAKING CHANGE: Locational endpoints support is not available in BigFrames 2.0.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated - screen/74LbU3BHHXHz63C

Fixes internal issue 379918500 🦕

@shobsi
chore!: drop support for locational endpoints
c0ac17a 
BREAKING CHANGE: Locational endpoints support is not available in BigFrames 2.0.
@shobsi shobsi requested review from a team as code owners March 25, 2025 23:59
@shobsi shobsi requested a review from shuoweil March 26, 2025 00:00
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 26, 2025
@shobsi shobsi requested a review from tswast March 26, 2025 01:04
tswast
tswast reviewed Mar 27, 2025
View reviewed changes
tswast
tswast requested changes Mar 27, 2025
View reviewed changes
tswast
tswast reviewed Mar 27, 2025
View reviewed changes
tswast
tswast reviewed Mar 27, 2025
View reviewed changes
@tswast tswast changed the title chore!: drop support for locational endpoints fix!: drop support for locational endpoints Mar 27, 2025
@tswast tswast changed the title fix!: drop support for locational endpoints feat!: drop support for locational endpoints Mar 27, 2025
@shobsi shobsi added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2025
tswast
tswast approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 4bf2e43 into main Mar 28, 2025
24 checks passed
@tswast tswast deleted the shobs-no-lep branch March 28, 2025 14:53
@release-please release-please bot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@shuoweil shuoweil shuoweil approved these changes

Assignees

@ivansmf ivansmf

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shobsi @tswast @shuoweil @ivansmf @yoshi-kokoro