Skip to content

docs: update snippet for Create a k-means model tutorial #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 5, 2025
Merged

docs: update snippet for Create a k-means model tutorial #1664

merged 13 commits into from
May 5, 2025

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Apr 28, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #412723079 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Apr 28, 2025
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Apr 28, 2025
@arwas11 arwas11 marked this pull request as ready for review May 2, 2025 19:40
@arwas11 arwas11 requested review from a team as code owners May 2, 2025 19:40
@arwas11 arwas11 requested review from vchudnov-g and GarrettWu May 2, 2025 19:40
@arwas11 arwas11 requested review from tswast and shobsi and removed request for vchudnov-g May 2, 2025 19:40
shobsi
shobsi reviewed May 2, 2025
View reviewed changes
@arwas11 arwas11 requested review from shobsi and removed request for GarrettWu May 5, 2025 13:50
tswast
tswast reviewed May 5, 2025
View reviewed changes
tswast
tswast reviewed May 5, 2025
View reviewed changes
tswast
tswast reviewed May 5, 2025
View reviewed changes
samples/snippets/create_kmeans_model_test.py Outdated
# data. These functions determine spatial relationships between
# geographical features.
# See, https://cloud.google.com/python/docs/reference/bigframes/latest/bigframes.geopandas.GeoSeries#bigframes_geopandas_GeoSeries_from_xy
# and https://cloud.google.com/python/docs/reference/bigframes/latest/bigframes.bigquery?_gl=1*zvtewl*_ga*MTQ0Mjc3NTA5NS4xNzQyOTI5NDMz*_ga_4LYFWVHBEB*MTc0NTg1OTY2Mi4zLjEuMTc0NTg2MDQ2Mi4wLjAuMA..#bigframes_bigquery_st_distance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean this link up a bit.

Suggested change
# and https://cloud.google.com/python/docs/reference/bigframes/latest/bigframes.bigquery?_gl=1*zvtewl*_ga*MTQ0Mjc3NTA5NS4xNzQyOTI5NDMz*_ga_4LYFWVHBEB*MTc0NTg1OTY2Mi4zLjEuMTc0NTg2MDQ2Mi4wLjAuMA..#bigframes_bigquery_st_distance.
# and https://cloud.google.com/python/docs/reference/bigframes/latest/bigframes.bigquery#bigframes_bigquery_st_distance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG! I'm noticing the current public API docs are not reflecting the changes you made in #1637. I'll try re-staging the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we are waiting for issue 414395527 to be fixed. Removing the links because the st_distance documentation is has not been staged yet.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels May 5, 2025
@arwas11 arwas11 requested a review from tswast May 5, 2025 16:15
@arwas11
Copy link
Contributor Author

arwas11 commented May 5, 2025

Notebook failure seems to be unrelated

=========================== short test summary info ============================
FAILED notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb::bq_dataframes_llm_kmeans.ipynb - IndexError: single positional indexer is out-of-bounds
======================== 1 failed in 248.20s (0:04:08) =========================
Benchmark failed, deleting: notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb.slotmillis
Benchmark failed, deleting: notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb.bytesprocessed
Benchmark failed, deleting: notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb.query_char_count
Benchmark failed, deleting: notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb.bq_exec_time_seconds
Benchmark failed, deleting: notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb.local_exec_time_seconds
notebooks/location/regionalized.ipynb .                                  [100%]

Learn more about nbmake at [https://github.com/treebeardtech/nbmake](https://www.google.com/url?q=https://github.com/treebeardtech/nbmake&sa=D)

tswast
tswast approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
Copy link
Collaborator

tswast commented May 5, 2025

Wait for samples tests to pass before merging.

@arwas11 arwas11 merged commit 761c364 into main May 5, 2025
23 of 24 checks passed
@arwas11 arwas11 deleted the b412723079-update-kmean-snippet branch May 5, 2025 17:09
@release-please release-please bot mentioned this pull request May 5, 2025
Merged
arwas11 added a commit that referenced this pull request May 5, 2025
@arwas11
Revert "docs: update snippet for Create a k-means model tutorial (#…
2dc12f8 
…1664)"

This reverts commit 761c364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@shobsi shobsi Awaiting requested review from shobsi

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arwas11 @tswast @shobsi @ericfe-google