feat: Implement ST_ISCLOSED geography function #1789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the `ST_ISCLOSED` geography function. The following changes were made: - Added `GeoIsClosedOp` to `bigframes/operations/geo_ops.py`. - Added `st_isclosed` function to `bigframes/bigquery/_operations/geo.py`. - Added `is_closed` property to `GeoSeries` in `bigframes/geopandas/geoseries.py`. - Added system tests for the `is_closed` property.
tswast
commented
Jun 3, 2025
tswast
commented
Jun 3, 2025
This commit implements the `ST_ISCLOSED` geography function. The following changes were made: - Added `GeoIsClosedOp` to `bigframes/operations/geo_ops.py`. - Added `st_isclosed` function to `bigframes/bigquery/_operations/geo.py`. - Added `is_closed` property to `GeoSeries` in `bigframes/geopandas/geoseries.py`. - Registered `GeoIsClosedOp` in `bigframes/core/compile/scalar_op_compiler.py` by defining an Ibis UDF and registering the op. - Added system checks for the `is_closed` property.
|
@shobsi I believe this is now ready for review. I addressed the failing system tests and moved the docstring to the correct location in |
|
e2e failure |
shobsi
reviewed
Jun 5, 2025
|
doctest failures appear unrelated: I believe this relates to the latest pandas update. Filed b/422994327 to fix. |
shobsi
previously approved these changes
Jun 9, 2025
|
TODO:
|
tswast
commented
Jun 9, 2025
shobsi
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the
ST_ISCLOSEDgeography function.The following changes were made:
GeoIsClosedOptobigframes/operations/geo_ops.py.st_isclosedfunction tobigframes/bigquery/_operations/geo.py.is_closedproperty toGeoSeriesinbigframes/geopandas/geoseries.py.is_closedproperty.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕