Skip to content

feat: df.to_pandas_batches() returns one empty DataFrame if df is empty #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

feat: df.to_pandas_batches() returns one empty DataFrame if df is empty #1878

merged 2 commits into from
Jul 7, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jul 1, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue b/428918844
Towards internal issue b/428700094
Related to #1841 (comment)
🦕

@tswast tswast requested review from a team as code owners July 1, 2025 19:07
@tswast tswast requested a review from GarrettWu July 1, 2025 19:07
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 1, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jul 1, 2025
@tswast
Copy link
Collaborator Author

tswast commented Jul 1, 2025

e2e failures:

=========================== short test summary info ============================
FAILED tests/system/large/streaming/test_bigtable.py::test_streaming_df_to_bigtable
= 1 failed, 373 passed, 6 skipped, 6 xfailed, 6 xpassed, 238 warnings, 2 retried in 1490.68s (0:24:50) =

notebook failures:

------------------------------ Captured log call -------------------------------
ERROR    traitlets:client.py:568 Error occurred while starting new kernel client for kernel 6b697f25-7265-4473-944b-615ef14436e9: Kernel didn't respond in 60 seconds

Learn more about nbmake at [https://github.com/treebeardtech/nbmake](https://www.google.com/url?q=https://github.com/treebeardtech/nbmake&sa=D)

============================== slowest durations ===============================
61.19s call     notebooks/geo/geoseries.ipynb::geoseries.ipynb

(2 durations < 0.005s hidden.  Use -vv to show these durations.)
=========================== short test summary info ============================
FAILED notebooks/geo/geoseries.ipynb::geoseries.ipynb - NBMAKE INTERNAL ERROR
========================= 1 failed in 61.31s (0:01:01) =========================
Exception ignored in atexit callback: <bound method run_sync.<locals>.wrapped of <nbcl

Samples failures:

=========================== short test summary info ============================
FAILED classification_boosted_tree_model_test.py::test_boosted_tree_model - g...
============ 1 failed, 27 passed, 42 warnings in 2989.94s (0:49:49) ============

None of these appear to be related to the changes I've made in this PR.

@tswast tswast enabled auto-merge (squash) July 7, 2025 18:37
@tswast tswast merged commit e43d15d into main Jul 7, 2025
18 of 25 checks passed
@tswast tswast deleted the b428918844-to_pandas_batches branch July 7, 2025 18:59
@release-please release-please bot mentioned this pull request Jul 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@jiaxunwu jiaxunwu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @GarrettWu @jiaxunwu