Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 5, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue b/436586523 🦕

@tswast tswast requested review from a team as code owners August 5, 2025 20:21
@tswast tswast requested a review from TrevorBergeron August 5, 2025 20:21
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 5, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Aug 5, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 5, 2025
@tswast
Copy link
Collaborator Author

tswast commented Aug 5, 2025

notebook tests are running, but I can see that bq_dataframes_llm_kmeans.ipynb passed already in the logs. That's a good sign!

@tswast
Copy link
Collaborator Author

tswast commented Aug 5, 2025

e2e failure is on unit_prerelease, not related to this change:

name = 'polars', import_ = <function _gcd_import at 0x7f3c21a284a0>

>   ???
E   ModuleNotFoundError: No module named 'polars'

@tswast tswast merged commit 25bde9f into main Aug 5, 2025
19 of 25 checks passed
@tswast tswast deleted the b436586523-ml-ai-job_retry branch August 5, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants