Skip to content

[WIP] Log __init__ calls of timedelta-related ops #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Log __init__ calls of timedelta-related ops #1561

wants to merge 5 commits into from

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Mar 28, 2025

No description provided.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 28, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 28, 2025
TrevorBergeron
TrevorBergeron requested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not log internal op initializers, or really anything not directly tied to user intentions or server requests? I worry this is very fragile.

@sycai
Copy link
Contributor Author

sycai commented Mar 31, 2025

Can we please not log internal op initializers, or really anything not directly tied to user intentions or server requests? I worry this is very fragile.

I need to gather metrics on the usage of timedelta ops, and it seems this is the most straightforward approach. Could you elaborate on the fragility?

@sycai sycai requested a review from TrevorBergeron March 31, 2025 22:00
@sycai
Copy link
Contributor Author

sycai commented Mar 31, 2025

Talked with @TrevorBergeron: the concern at the moment is that this PR is trying to log internal mechanisms instead of user intentions, which deviates from the purpose of the class_logger.

Putting this PR on hold for now.

@sycai sycai added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sycai @TrevorBergeron