feat: Add simple stats support to hybrid local pushdown #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Jul 1, 2025
bigframes/testing/engine_utils.py
Outdated
| @@ -26,6 +28,7 @@ def assert_equivalence_execution( | |||
| assert e1_result is not None | |||
| assert e2_result is not None | |||
| # Schemas might have extra nullity markers, normalize to node expected schema, which should be looser | |||
There was a problem hiding this comment.
Looks like this comment no longer applies since you aren't casting here.
| @@ -25,6 +25,25 @@ | |||
| REFERENCE_ENGINE = polars_executor.PolarsExecutor() | |||
|
|
|||
|
|
|||
| def apply_agg_to_all_valid( | |||
| array: array_value.ArrayValue, op: agg_ops.UnaryAggregateOp, excluded_cols=[] | |||
| ) -> array_value.ArrayValue: | |||
There was a problem hiding this comment.
I can make some assumptions as to this helper function's purpose from the name, but a docstring would be lovely to clarify.
There was a problem hiding this comment.
added simple docstring
tswast
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕