Skip to content

fix: correct min field from max() to min() in remote function tests #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix: correct min field from max() to min() in remote function tests #1917

merged 1 commit into from
Jul 17, 2025

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Jul 17, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 17, 2025
@jialuoo jialuoo requested a review from Genesis929 July 17, 2025 21:30
@jialuoo jialuoo self-assigned this Jul 17, 2025
@jialuoo jialuoo marked this pull request as ready for review July 17, 2025 21:30
@jialuoo jialuoo requested review from a team as code owners July 17, 2025 21:30
@jialuoo jialuoo enabled auto-merge (squash) July 17, 2025 21:31
@jialuoo jialuoo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2025
@jialuoo jialuoo merged commit d5c54fc into main Jul 17, 2025
24 of 25 checks passed
@jialuoo jialuoo deleted the fix-test branch July 17, 2025 23:45
@release-please release-please bot mentioned this pull request Jul 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Genesis929 Genesis929 Genesis929 approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialuoo @Genesis929