chore: fix ops.ToTimedeltaOp and ops.IsInOp sqlglot compiler #2039
+133
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycai
previously approved these changes
Aug 28, 2025
|
|
||
| sql = _apply_unary_op(bf_df, ops.IsInOp(values=(1, 2, 3)), "int64_col") | ||
| snapshot.assert_match(sql, "out.sql") |
There was a problem hiding this comment.
nit: empty lines before assertions.
sycai
previously approved these changes
Aug 28, 2025
|
looks like there is still an |
489282f to
7ba1166
Compare
auto-merge was automatically disabled
August 29, 2025 21:42
Pull request was converted to draft
|
Waiting for #2043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 430133370 🦕