Skip to content

test: enable tests on Windows #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 8, 2024
Merged

test: enable tests on Windows #857

merged 12 commits into from
Aug 8, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jul 24, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 335815619
🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 24, 2024
@tswast tswast added kokoro:run Add this label to force Kokoro to re-run the tests. and removed size: m Pull request size is medium. labels Jul 24, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jul 24, 2024
@bigframes-bot bigframes-bot removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 24, 2024
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 5, 2024
@tswast
Copy link
Collaborator Author

tswast commented Aug 7, 2024

Windows build was "successful", but didn't actually launch Python.


C:\tmpfs\src>set PYTHON_VERSION=P 

C:\tmpfs\src>if "P" == "" (
echo "Python version was not provided, using Python 3.10"  
 set PYTHON_VERSION=3.10 
) 

C:\tmpfs\src>py -P-64 -m pip install --no-index --find-links=wheels bigframes --force-reinstall 
Unknown option: -P
usage: C:\Program Files\Python310\python.exe [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

C:\tmpfs\src>py -P-64 -m pip install pytest 
Unknown option: -P
usage: C:\Program Files\Python310\python.exe [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

C:\tmpfs\src>py -P-64 -m pytest tests/unit 
Unknown option: -P
usage: C:\Program Files\Python310\python.exe [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

C:\tmpfs\src>py -P-64 -m pytest tests/system/small 
Unknown option: -P
usage: C:\Program Files\Python310\python.exe [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

C:\tmpfs\src>echo "Windows build has completed successfully" 
"Windows build has completed successfully"


[ID: 3448397] Command finished after 38 secs, exit value: 0

Edit: Fixed. And updated the script to return correct exit code on failure.

@tswast tswast marked this pull request as ready for review August 7, 2024 19:22
@tswast tswast requested review from a team as code owners August 7, 2024 19:22
@tswast tswast requested a review from shobsi August 7, 2024 19:22
@tswast tswast enabled auto-merge (squash) August 8, 2024 18:32
@tswast tswast merged commit 0c011a8 into main Aug 8, 2024
23 checks passed
@tswast tswast deleted the b33581561-windows branch August 8, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants