Skip to content

flake: test_table_create can cause table list test to fail #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tswast opened this issue Apr 13, 2021 · 0 comments · Fixed by #124
Closed

flake: test_table_create can cause table list test to fail #123

tswast opened this issue Apr 13, 2021 · 0 comments · Fixed by #124
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Apr 13, 2021

https://source.cloud.google.com/results/invocations/a16ca408-bdaf-4a0d-9c02-d2d1c149f427/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery-sqlalchemy%2Fpresubmit%2Fpresubmit/log

nox > Running session system-3.8
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/system-3-8
nox > python -m pip install --pre grpcio
nox > python -m pip install mock pytest google-cloud-testutils -c /tmpfs/src/github/python-bigquery-sqlalchemy/testing/constraints-3.8.txt
nox > python -m pip install -e . -c /tmpfs/src/github/python-bigquery-sqlalchemy/testing/constraints-3.8.txt
nox > py.test --quiet --junitxml=system_3.8_sponge_log.xml tests/system
..............................F.............                             [100%]
=================================== FAILURES ===================================
__________________________ test_table_names_in_schema __________________________

inspector = <sqlalchemy.engine.reflection.Inspector object at 0x7f33fdaa8c70>
inspector_using_test_dataset = <sqlalchemy.engine.reflection.Inspector object at 0x7f33fdaa8eb0>

    def test_table_names_in_schema(inspector, inspector_using_test_dataset):
        tables = inspector.get_table_names("test_pybigquery")
        assert "test_pybigquery.sample" in tables
        assert "test_pybigquery.sample_one_row" in tables
        assert "test_pybigquery.sample_view" not in tables
        assert len(tables) == 2

        tables = inspector_using_test_dataset.get_table_names()
        assert "sample" in tables
        assert "sample_one_row" in tables
        assert "sample_view" not in tables
>       assert len(tables) == 2
E       AssertionError: assert 3 == 2
E        +  where 3 = len(['sample', 'sample_one_row', 'test_table_create'])

tests/system/test_sqlalchemy_bigquery.py:584: AssertionError
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Apr 13, 2021
@tswast tswast self-assigned this Apr 13, 2021
@tswast tswast added type: cleanup An internal cleanup or hygiene concern. type: process A process-related concern. May include testing, release, or the like. and removed type: cleanup An internal cleanup or hygiene concern. labels Apr 13, 2021
@tswast tswast mentioned this issue Apr 13, 2021
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 13, 2021
@tswast
test: move table creation to temporary dataset (#124)
9179193 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #123 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: move table creation to temporary dataset tswast/python-bigquery-sqlalchemy
1 participant
@tswast