Skip to content

Python 3.10 support #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkashapov opened this issue Nov 7, 2021 · 4 comments · Fixed by #381
Closed

Python 3.10 support #374

rkashapov opened this issue Nov 7, 2021 · 4 comments · Fixed by #381
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rkashapov
Copy link

Hello!

It would be great to get python 3.10 supported by this excellent package.

Thanks,
Rustam

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Nov 7, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 8, 2021
@meredithslota meredithslota added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 9, 2021
@tswast
Copy link
Collaborator

tswast commented Nov 17, 2021

Thanks for the request!

This will require some investigation. Current Python 3.10 tests fail with

ERROR: No matching distribution found for Fiona==1.8.20

https://source.cloud.google.com/results/invocations/5f015b38-5fa3-4c33-9d7e-729756858ac5/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery-sqlalchemy%2Fsamples%2Fpython3.10%2Fcontinuous/log

@aucampia
Copy link
Contributor

@tswast Is there a reason the versions in here are hard-coded?

I'm thinking of just making a patch to add requirements.in and requirements-test.in and then use pip-compile on those, any objections to this?

@aucampia
Copy link
Contributor

And just to clarify, if this is blocked because Fiona==1.8.20 does not support python 3.10 then it will never unblock because pypi version should be immutable, so ideally it should be Fiona in general, and the right way to then vary that is with pip-compile I think (or something more advanced).

@aucampia
Copy link
Contributor

I'm unclear on what Fiona was for, but test seem to pass for 3.10 if I make a requirements.txt from a sane requirements.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants