Skip to content

project_id is ignored when using service account with different project id #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mindartur opened this issue Feb 11, 2020 · 3 comments
Closed

Comments

@mindartur
Copy link

Whatever options is used, can't override project ID from service account

@tswast
Copy link
Collaborator

tswast commented Feb 11, 2020

Looks like we need to update https://github.com/mxmzdlv/pybigquery/blob/1a76103a445de6ad9bb329346ecf075d1255a118/pybigquery/sqlalchemy_bigquery.py#L303 to pass the url.host to self._create_client_from_credentials.

Pull requests welcome.

@alonme
Copy link
Contributor

alonme commented Apr 23, 2020

@tswast we can resolve this issue, as it is now merged in available in the release

@tswast tswast closed this as completed Apr 24, 2020
@tswast
Copy link
Collaborator

tswast commented Mar 31, 2021

I add some unit tests for this in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants