-
Notifications
You must be signed in to change notification settings - Fork 138
Problem with SQLAlchemy 1.4.0 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Facing the same problem. |
Can you please share a code snippet which generates this error? |
Here is snippet. Just use table that you have access to
here is requirements.txt for this example
pip freeze:
python --version:
|
when you change requirements.txt to:
example works just fine |
it seems like SQLAlchemy 1.4.0, also breaks a lot of other features (23 tests fail) |
I updated the maximum sqlalchemy version in 37e584e#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R67 to limit to 1.3.x and below. As such, I'm converting this issue to a feature request (to support 1.4.x). From https://docs.sqlalchemy.org/en/14/changelog/migration_14.html is sounds like there have been conceptual changes, so this may require significant work to get right. |
Any update on the timeline for support for sqlalchemy 1.4? |
I'm working on it now. :) Hopefully, this week. |
@jimfulton Started a PR, couldn't find the time to finish it until now, Did you see it? |
I didn't until you pointed it out.
I'm nearly finished with my work, which builds on:
My work is here: https://github.com/googleapis/python-bigquery-sqlalchemy/compare/riversnake-sqla-14 ATM, I'm trying to figure out why some code paths I added while debugging the compliance tests initially are no-longer being hit. :/ |
Lots of code there! i did some work to rebase my branch, but i think that you implemented all the fixes i did already. so i have a branch with those applied and where all current tests work. does your branch also work on older versions of SQLA? |
There was lots of code in the tests work. With that in place, the 1.4 port isn't too bad. :)
Cool.
It should work with the latest 1.2, 1.3, and 1.4 versions. I dropped support for 1.1 (on master) when I added comment support. |
The PR: #177 More eyes would be welcome. Feel free to ask questions or to request more comments. |
@alonme any interest in taking a look? Or did you already? |
Release 0.8.0 supports SQLAlchemy 1.4. |
I am currently getting the same error. SQLAlchemy==1.4.39 Any clues as to what might be the case now?
|
i'm having the same problem
|
Hello,
New version of SQLAlchemy (1.4.0) was released 15.03.2020 and since then I got following error:
I rolled back to SQLAlchemy==1.3.20 and it works fine.
The text was updated successfully, but these errors were encountered: