Skip to content

Remove tests and specific code for sqlalchemy versions < 1.4 #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kiraksi opened this issue Dec 18, 2023 · 0 comments · Fixed by #987
Closed

Remove tests and specific code for sqlalchemy versions < 1.4 #934

kiraksi opened this issue Dec 18, 2023 · 0 comments · Fixed by #987
Assignees
@kiraksi
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: cleanup An internal cleanup or hygiene concern.

Comments

@kiraksi
Copy link
Contributor

kiraksi commented Dec 18, 2023 •
edited
Loading

Now that we are adding support for sqlalchemy 2.0+ with 1.4 compatibility, and dropping support for sqlalchemy 1.2 and 1.3 in #920 , we should remove tests and functions that are only for the dropped versions of sqlalchemy to cleanup library after migration. This will hopefully fix some cover issues in kokoro
@kiraksi kiraksi added the type: cleanup An internal cleanup or hygiene concern. label Dec 18, 2023
@kiraksi kiraksi self-assigned this Dec 18, 2023
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Dec 18, 2023
@tswast tswast mentioned this issue Dec 19, 2023
Closed
@kiraksi kiraksi mentioned this issue Jan 10, 2024
Merged
4 tasks
@kiraksi kiraksi closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiraksi kiraksi

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix coverage tests sqlalchemy 2.0 migration kiraksi/python-bigquery-sqlalchemy
1 participant
@kiraksi