Skip to content

tests.system.test_sqlalchemy_bigquery: many tests failed #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flaky-bot bot opened this issue Mar 25, 2021 · 3 comments · Fixed by #101
Closed

tests.system.test_sqlalchemy_bigquery: many tests failed #99

flaky-bot bot opened this issue Mar 25, 2021 · 3 comments · Fixed by #101
Assignees
@tswast
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Mar 25, 2021

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

  • test_dry_run
  • test_engine_with_dataset
  • test_dataset_location
  • test_reflect_select
  • test_content_from_raw_queries
  • test_record_content_from_raw_queries
  • test_content_from_reflect
  • test_unicode
  • test_reflect_select_shared_table
  • test_reflect_table_does_not_exist
  • test_reflect_dataset_does_not_exist
  • test_tables_list
  • test_group_by
  • test_nested_labels
  • test_session_query
  • test_labels
  • test_custom_expression
  • test_compiled_query_literal_binds
  • test_compile_types[column0-STRING]
  • test_compile_types[column1-NUMERIC]
  • test_compile_types[column2-ARRAY]
  • test_joins
  • test_querying_wildcard_tables
  • test_dml
  • test_create_table
  • test_schemas_names
  • test_table_names_in_schema
  • test_view_names
  • test_get_indexes
  • test_get_columns
  • test_table_reference[dataset-table-project]
  • test_table_reference[None-dataset.table-project]
  • test_table_reference[None-project.dataset.table-other_project]
  • test_table_reference[project-dataset.table-other_project]
  • test_table_reference[project.dataset-table-other_project]
  • test_invalid_table_reference[project.dataset-other_dataset.table-project]
  • test_invalid_table_reference[project.dataset-other_project.dataset.table-project]
  • test_invalid_table_reference[project.dataset.something_else-table-project]
  • test_invalid_table_reference[None-project.dataset.table.something_else-project]
  • test_has_table

commit: 1707737
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 25, 2021
@alonme
Copy link
Contributor

alonme commented Mar 25, 2021

@tswast - Was just about the open an issue about running some sort of CI.

What triggers that? is it possible to run on PRs?

BTW - seems like it fails because the datasets/tables were not created - maybe we can add that as a fixture or set up of some sort?

@tswast
Copy link
Collaborator

tswast commented Mar 25, 2021

@alonme Yeah, that's right. We now have nightly CI that files bugs when there are test failures. 😁

What triggers that? is it possible to run on PRs?

It's a Google-internal CI system called Kokoro. I can add a kokoro: force-run to PRs to make it run the test suite.

BTW - seems like it fails because the datasets/tables were not created - maybe we can add that as a fixture or set up of some sort?

I added a fixture, but it looks like maybe there's a race condition between creating the tables and creating the views that depend on them. I'll look into this.

@tswast tswast self-assigned this Mar 25, 2021
@tswast tswast mentioned this issue Mar 25, 2021
Merged
4 tasks
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Mar 26, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 26, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (1707737), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: only create test tables if they do not already exist tswast/python-bigquery-sqlalchemy
2 participants
@tswast @alonme