Skip to content

'HTTPDatastoreAPI' does not support 'reserveIds' API #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tseaver opened this issue Dec 9, 2020 · 0 comments · Fixed by #136
Closed

'HTTPDatastoreAPI' does not support 'reserveIds' API #134

tseaver opened this issue Dec 9, 2020 · 0 comments · Fixed by #136
Assignees
@tseaver
Labels
api: datastore Issues related to the googleapis/python-datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Dec 9, 2020

This issue would surface if trying to use Client.reserve_ids with the GOOGLE_CLOUD_DISABLE_GRPC envvar set.
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 9, 2020
@tseaver tseaver self-assigned this Dec 9, 2020
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Dec 9, 2020
tseaver added a commit that referenced this issue Dec 9, 2020
@tseaver
fix: add missing 'HTTPDatastoreAPI.reserve_ids' method
276464f 
Closes #134.
@tseaver tseaver mentioned this issue Dec 9, 2020
Merged
crwilcox pushed a commit that referenced this issue Dec 9, 2020
@tseaver
fix: make HTTPDatastoreAPI compatible w/ microgen Gapic API (#136)
d522799 
* tests: refactor to helpers for repeated tests

* fix: update 'HTTPDatastoreAPI.allocate_ids' to follow request-only pattern

Toward #124

* fix: add missing 'HTTPDatastoreAPI.reserve_ids' method

Closes #134.

* fix: update 'HTTPDatastoreAPI.rollback' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.commit' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.begin_transaction' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.run_query' to follow request-only pattern

Toward #124

* fix: update 'HTTPDatastoreAPI.lookup' to follow request-only pattern

Toward #124

* fix: add 'retry' / 'timeout' args to HTTPDatastoreAPI methods

Closes #124.

* chore: lint

* tests: run systests also w/ GRPC disabled.

Closes #133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the googleapis/python-datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make HTTPDatastoreAPI compatible w/ microgen Gapic API googleapis/python-datastore
1 participant
@tseaver