Skip to content

Bump google-cloud-logging version specifier to be compatible with 2.3 (ideally 2.x) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snarfed opened this issue Mar 23, 2021 · 1 comment
Assignees
Labels
api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@snarfed
Copy link

snarfed commented Mar 23, 2021

HI all! Thank you for building and maintaining google-cloud-error-reporting. It's great!

google-cloud-logging recently released a new version, 2.3, but google-cloud-error-reporting isn't compatible with it because of this version specifier in setup.py:

"google-cloud-logging>=1.14.0, <2.3",

Pip log:

$ pip install google-cloud-error-reporting==1.1.1 google-cloud-logging==2.3
...
ERROR: Cannot install google-cloud-error-reporting==1.1.1 and google-cloud-logging==2.3 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested google-cloud-logging==2.3
    google-cloud-error-reporting 1.1.1 depends on google-cloud-logging<2.2 and >=1.14.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

Basically the same issue as #42. Mind bumping that line to <3.0? I know 2.0 was a big backward incompatible release, but semver willing, hopefully there won't be another one of those until 3.0.

Thanks in advance!

Environment details

  • OS type and version: Ubuntu, Mac OS 11.2.3
  • Python version: 3.7.3, 3.9.2
  • pip version: , 21.0.1
  • google-cloud-error-reporting version: 1.1.1
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. label Mar 23, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 24, 2021
@daniel-sanche
Copy link
Contributor

Yes, thanks for catching that! I merged the dependency PR, and will cut a new release this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants