Skip to content

[DRAFT] feat: Pipeline queries cleanup #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: pipeline_queries_4_all
Choose a base branch
from

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jul 12, 2025

This draft PR implements naming changes described here: googleapis/google-cloud-go#12538 (comment)

In our team API discussion and feedback from other reviewers, there are many changes not applied to Java yet. I will try to list them all here, based on the differences I see in your diagram.

FilterCondition is renamed to BooleanExpr
Accumulator is renamed AggregateFunction
AggregateFunction no longer inherits from Function, but is instead root of separate inheritance tree.
AccumulatorTarget is renamed to AliasedAggregate
AliasedAggregate does not implement Selectable interface
ExprWithAlias is renamed to AliasedExpr
Return values of boolean operators 'Eq', 'Neq', etc should be BooleanExpr (the actual EqCondition >and NeqCondition classes are an implementation detail that should appear in customer code). >Likewise, return values for Add and Subtract should be Expr. And so forth...

We will update this as names continue to evolve

TODO:

  • better encapsule expressions and stages from end users?

    • some of them are exposed publicly, but we want them to be more internal/hidden. Maybe move them
  • get tests and lint passing

  • add tests for new AggregateAlias class

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/python-firestore API. labels Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant