fix!: api consistency between HTTP and Gapic layers #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
added a commit
that referenced
this pull request
Jan 27, 2022
daniel-sanche
added a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the staged v3.0.0 branch
We have two separate transport options for this library: gRPC and HTTP. They expose the same interface, but previously returned different types.
This PR wraps the HTTP
list_*functions in a python generator, consistent with how the gRPC version works. Additionally, it adds a newmax_resultsargument, so users can decide how many objects they want to return before stopping. This new argument will work consistently for both options.Fixes #154, #136, #203