Skip to content

feat: add retry and timeout for batch dml #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2024
Merged

feat: add retry and timeout for batch dml #1107

merged 7 commits into from
Mar 6, 2024

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Feb 26, 2024 •
edited
Loading

Fixes b/326596176

This PR makes the following changes

  1. allows setting retry and timeout to batch_update method. This PR feat: add support for custom timeout and retry parameters in execute_update method in transactions #251 added changes only to few methods.
  2. Add a public sample for retry and timeout. https://cloud.google.com/spanner/docs/custom-timeout-and-retry

Fixes #927

@harshachinta harshachinta requested review from a team as code owners February 26, 2024 11:53
@harshachinta harshachinta requested a review from ohmayr February 26, 2024 11:53
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Feb 26, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Feb 26, 2024
surbhigarg92
surbhigarg92 reviewed Mar 6, 2024
View reviewed changes
surbhigarg92
surbhigarg92 approved these changes Mar 6, 2024
View reviewed changes
harshachinta
harshachinta commented Mar 6, 2024
View reviewed changes
@harshachinta harshachinta enabled auto-merge (squash) March 6, 2024 11:29
@harshachinta harshachinta merged commit 4f6340b into googleapis:main Mar 6, 2024
@release-please release-please bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@ohmayr ohmayr Awaiting requested review from ohmayr ohmayr is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sample for passing timeout and retry parameters
2 participants
@harshachinta @surbhigarg92