Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

feat: Specifying language code and display name for text and audio streams is now supported #288

Merged
merged 2 commits into from
Mar 1, 2023
Merged

feat: Specifying language code and display name for text and audio streams is now supported #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a73e69d
feat: Specifying language code and display name for text and audio st…
gcf-owl-bot[bot] Mar 1, 2023
ee80e55
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions google/cloud/video/transcoder_v1/types/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2043,6 +2043,13 @@ class AudioStream(proto.Message):
sample_rate_hertz (int):
The audio sample rate in Hertz. The default
is 48000 Hertz.
language_code (str):
The BCP-47 language code, such as ``en-US`` or ``sr-Latn``.
For more information, see
https://www.unicode.org/reports/tr35/#Unicode_locale_identifier.
display_name (str):
The name for this particular audio stream
that will be added to the HLS/DASH manifest.
"""

class AudioMapping(proto.Message):
Expand Down Expand Up @@ -2120,6 +2127,14 @@ class AudioMapping(proto.Message):
proto.INT32,
number=6,
)
language_code: str = proto.Field(
proto.STRING,
number=7,
)
display_name: str = proto.Field(
proto.STRING,
number=8,
)


class TextStream(proto.Message):
Expand All @@ -2137,9 +2152,16 @@ class TextStream(proto.Message):
- ``cea608``
- ``cea708``
- ``webvtt``
language_code (str):
The BCP-47 language code, such as ``en-US`` or ``sr-Latn``.
For more information, see
https://www.unicode.org/reports/tr35/#Unicode_locale_identifier.
mapping_ (MutableSequence[google.cloud.video.transcoder_v1.types.TextStream.TextMapping]):
The mapping for the ``Job.edit_list`` atoms with text
``EditAtom.inputs``.
display_name (str):
The name for this particular text stream that
will be added to the HLS/DASH manifest.
"""

class TextMapping(proto.Message):
Expand Down Expand Up @@ -2174,11 +2196,19 @@ class TextMapping(proto.Message):
proto.STRING,
number=1,
)
language_code: str = proto.Field(
proto.STRING,
number=2,
)
mapping_: MutableSequence[TextMapping] = proto.RepeatedField(
proto.MESSAGE,
number=3,
message=TextMapping,
)
display_name: str = proto.Field(
proto.STRING,
number=4,
)


class SegmentSettings(proto.Message):
Expand Down
2 changes: 1 addition & 1 deletion samples/generated_samples/snippet_metadata_google.cloud.video.transcoder.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-video-transcoder",
"version": "1.7.0"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/gapic/transcoder_v1/test_transcoder_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3207,16 +3207,20 @@ def test_create_job_rest(request_type):
}
],
"sample_rate_hertz": 1817,
"language_code": "language_code_value",
"display_name": "display_name_value",
},
"text_stream": {
"codec": "codec_value",
"language_code": "language_code_value",
"mapping_": [
{
"atom_key": "atom_key_value",
"input_key": "input_key_value",
"input_track": 1188,
}
],
"display_name": "display_name_value",
},
}
],
Expand Down Expand Up @@ -3622,16 +3626,20 @@ def test_create_job_rest_bad_request(
}
],
"sample_rate_hertz": 1817,
"language_code": "language_code_value",
"display_name": "display_name_value",
},
"text_stream": {
"codec": "codec_value",
"language_code": "language_code_value",
"mapping_": [
{
"atom_key": "atom_key_value",
"input_key": "input_key_value",
"input_track": 1188,
}
],
"display_name": "display_name_value",
},
}
],
Expand Down Expand Up @@ -4796,16 +4804,20 @@ def test_create_job_template_rest(request_type):
}
],
"sample_rate_hertz": 1817,
"language_code": "language_code_value",
"display_name": "display_name_value",
},
"text_stream": {
"codec": "codec_value",
"language_code": "language_code_value",
"mapping_": [
{
"atom_key": "atom_key_value",
"input_key": "input_key_value",
"input_track": 1188,
}
],
"display_name": "display_name_value",
},
}
],
Expand Down Expand Up @@ -5206,16 +5218,20 @@ def test_create_job_template_rest_bad_request(
}
],
"sample_rate_hertz": 1817,
"language_code": "language_code_value",
"display_name": "display_name_value",
},
"text_stream": {
"codec": "codec_value",
"language_code": "language_code_value",
"mapping_": [
{
"atom_key": "atom_key_value",
"input_key": "input_key_value",
"input_track": 1188,
}
],
"display_name": "display_name_value",
},
}
],
Expand Down