Skip to content

Create a Builder class for GrpcCallContext #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rockspore opened this issue Mar 7, 2025 · 0 comments
Open

Create a Builder class for GrpcCallContext #3681

rockspore opened this issue Mar 7, 2025 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@rockspore
Copy link
Member

With a builder, PRs like #3670 that introduce new class members to GrpcCallContext will be largely simplified and less error-prone withtout having to touch the private constructor.
@rockspore rockspore mentioned this issue Mar 7, 2025
Merged
@blakeli0 blakeli0 added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blakeli0 @rockspore