You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revert "Handle GOARCH env var similarly to cmd/go." (#605)
This reverts commit 62bca28.
We've originally discussed two possible fixes in issue #594:
> The gopherjs tool does not use the GOARCH environment variable
> in any way. Internally, GopherJS always uses js as GOARCH value
> when compiling user code, but it does other internal stuff when
> compiling standard library.
>
> 1. One fix is to make the gopherjs tool really ignore GOARCH env
> var. In other words, setting it to any value should have no effect;
> it shouldn't cause this failure.
>
> 2. We could also consider making it use the value of GOARCH, and
> error out if it's set to anything other than js (which is the
> default and the only supported value). Since gopherjs can't compile
> for any other architectures.
Upon further consideration, after seeing issue #601 and gopherjs/gopherjs.github.io#66,
we've decided (see discussion in gopherjs/gopherjs.github.io#66 (comment))
to revisit this issue and change gopherjs to completely ignore GOARCH
environment variable, instead of requiring it to be unset or equal to js.
Closes#601.
Updates #594.
0 commit comments