Allow disabling gorepo tests only on Windows

flimzy · flimzy · commit 322f28876040 · 2023-11-02T16:05:12.000+01:00
diff --git a/tests/gorepo/run.go b/tests/gorepo/run.go
@@ -46,6 +46,8 @@ import (
 //
 // TODO: Reduce these to zero or as close as possible.
 var knownFails = map[string]failReason{
+	"fixedbugs/issue22083.go": {category: brokenOnWindows, desc: "stack trace differs on Windows"},
+
 	"fixedbugs/bug114.go":     {desc: "fixedbugs/bug114.go:15:27: B32 (untyped int constant 4294967295) overflows int"},
 	"fixedbugs/bug242.go":     {desc: "bad map check 13 false false Error: fail"},
 	"fixedbugs/bug260.go":     {desc: "maybe unsupportedFeature, pointer arithm"},
@@ -169,6 +171,7 @@ const (
 	unsureIfGopherJSSupportsThisFeature
 	lowLevelRuntimeDifference // JavaScript runtime behaves differently from Go in ways that are difficult to work around.
 	notApplicable             // Test that doesn't need to run under GopherJS; it doesn't apply to the Go language in a general way.
+	brokenOnWindows           // Tests fail only on Windows
 )
 
 type failReason struct {
@@ -287,7 +290,12 @@ func main() {
 		status := "ok  "
 		errStr := ""
 		// GOPHERJS.
-		if _, ok := knownFails[filepath.ToSlash(test.goFileName())]; ok && test.err != nil {
+		knownFail, ok := knownFails[filepath.ToSlash(test.goFileName())]
+		if ok && runtime.GOOS != "windows" && knownFail.category == brokenOnWindows {
+			// Only disable brokenOnWindows tests if we're running on Windows
+			ok = false
+		}
+		if ok && test.err != nil {
 			errStr = test.err.Error()
 			test.err = nil
 			status = "knfl" // knfl means known failure. Expect test to fail.
