Compute binary name from base of directory rather than import path. (#702)

4ydx · dmitshur · commit 415225646bb9 · 2017-09-27T15:27:36.000-04:00
When building a package that lies outside of a GOPATH, its import path will be local, and its base might be unsuitable for figuring out the binary name. Instead, use the base of the absolute path to the directory where the package is located. Do so even for packages that are inside a GOPATH workspace. It should produce identical results. As of right now, there are no known cases where that's not true, but if any are discovered and reported, we can fall back to using base of import path as long as build.IsLocalImport(pkg.ImportPath) returns false. Fixes #699.
diff --git a/tool.go b/tool.go
@@ -143,7 +143,7 @@ func main() {
 					}
 					if len(pkgs) == 1 { // Only consider writing output if single package specified.
 						if pkgObj == "" {
-							pkgObj = filepath.Base(pkg.ImportPath) + ".js"
+							pkgObj = filepath.Base(pkg.Dir) + ".js"
 						}
 						if pkg.IsCommand() && !pkg.UpToDate {
 							if err := s.WriteCommandPackage(archive, pkgObj); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ func main() {`
`143`	`143`	`}`
`144`	`144`	`if len(pkgs) == 1 { // Only consider writing output if single package specified.`
`145`	`145`	`if pkgObj == "" {`
`146`		`- pkgObj = filepath.Base(pkg.ImportPath) + ".js"`
	`146`	`+ pkgObj = filepath.Base(pkg.Dir) + ".js"`
`147`	`147`	`}`
`148`	`148`	`if pkg.IsCommand() && !pkg.UpToDate {`
`149`	`149`	`if err := s.WriteCommandPackage(archive, pkgObj); err != nil {`