compiler/natives/src/reflect: Set pkgPath for new implements checks.

dmitshur · dmitshur · commit 44d151dccc53 · 2017-08-25T14:19:47.000-04:00
In Go 1.9, specifically commit golang/go@2ddc3e9, reflect.implements was modified to look at pkgPath in more cases. Previously, GopherJS didn't always set pkgPath in some places. This caused panics and failures in TestImplements and TestAssignableTo. This change fixes that, allowing all reflect tests to pass. Fixes: $ go install -tags=gopherjsdev -v && touch $(which gopherjs) && gopherjs test --short reflect --- FAIL: TestImplements (0.00s) /Users/Dmitri/Dropbox/Work/2013/GoLand/src/github.com/gopherjs/gopherjs/test.903476986:1412 throw new Error(msg); ^ Error: runtime error: invalid memory address or nil pointer dereference ... FAIL reflect 4.658s
diff --git a/compiler/natives/src/reflect/reflect.go b/compiler/natives/src/reflect/reflect.go
@@ -122,6 +122,7 @@ func reflectType(typ *js.Object) *rtype {
 			}
 			setKindType(rt, &interfaceType{
 				rtype:   *rt,
+				pkgPath: newName(internalStr(typ.Get("pkg")), "", "", false),
 				methods: imethods,
 			})
 		case Map:
diff --git a/compiler/prelude/types.go b/compiler/prelude/types.go
@@ -234,7 +234,7 @@ var $newType = function(size, kind, string, named, pkg, exported, constructor) {
   case $kindStruct:
     typ = function(v) { this.$val = v; };
     typ.wrapped = true;
-    typ.ptr = $newType(4, $kindPtr, "*" + string, false, "", exported, constructor);
+    typ.ptr = $newType(4, $kindPtr, "*" + string, false, pkg, exported, constructor);
     typ.ptr.elem = typ;
     typ.ptr.prototype.$get = function() { return this; };
     typ.ptr.prototype.$set = function(v) { typ.copy(this, v); };

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,7 @@ func reflectType(typ js.Object) rtype {`
`122`	`122`	`}`
`123`	`123`	`setKindType(rt, &interfaceType{`
`124`	`124`	`rtype: *rt,`
	`125`	`+ pkgPath: newName(internalStr(typ.Get("pkg")), "", "", false),`
`125`	`126`	`methods: imethods,`
`126`	`127`	`})`
`127`	`128`	`case Map:`