Correctly recognize type conversion expressions with multiple typeparams.

nevkontakte · nevkontakte · commit 4e6c8bcb00dc · 2023-11-01T23:22:46.000Z
Prior to this change expressions like `ss[T1, T2](val)` where `ss` is a
parameterized type were not recognized as type conversion expressions
due to use of the *ast.IndexListExpr node.
diff --git a/compiler/astutil/astutil.go b/compiler/astutil/astutil.go
@@ -60,6 +60,13 @@ func IsTypeExpr(expr ast.Expr, info *types.Info) bool {
 		}
 		_, ok = info.Uses[ident].(*types.TypeName)
 		return ok
+	case *ast.IndexListExpr:
+		ident, ok := e.X.(*ast.Ident)
+		if !ok {
+			return false
+		}
+		_, ok = info.Uses[ident].(*types.TypeName)
+		return ok
 	case *ast.ParenExpr:
 		return IsTypeExpr(e.X, info)
 	default:
diff --git a/tests/gorepo/run.go b/tests/gorepo/run.go
@@ -172,7 +172,7 @@ var knownFails = map[string]failReason{
 	"typeparam/issue48453.go":        {category: generics, desc: "make() doesn't support generic slice types"},
 	"typeparam/issue49295.go":        {category: generics, desc: "len() doesn't support generic pointer to array types"},
 	"typeparam/issue50193.go":        {category: generics, desc: "invalid print format for complex numbers"},
-	"typeparam/issue51303.go":        {category: generics, desc: "missing support for conversion into a parameterized type"},
+	"typeparam/issue51303.go":        {category: generics, desc: "missing support for range over type parameter"},
 	"typeparam/issue51522a.go":       {category: generics, desc: "missing support for the comparable type constraint"},
 	"typeparam/issue51522b.go":       {category: generics, desc: "missing support for the comparable type constraint"},
 	"typeparam/list.go":              {category: generics, desc: "missing operator support for generic types"},
