Fix issue where specifying specific test to run failed to run it.

dmitshur · dmitshur · commit 68f13c385cf0 · 2015-09-07T01:13:56.000-07:00
It was because filepath.Split left a trailing slash after dir, so
"fixedbugs/" != "fixedbugs". Use filepath.Clean on input t.dir to
resolve this.

Remove another completed TODO.
diff --git a/tests/run.go b/tests/run.go
@@ -217,10 +217,6 @@ func main() {
 		}
 	} else {
 		for _, dir := range dirs {
-			// GOPHERJS.
-			// TODO: Make this work so test filter doesn't break, etc.
-			//dir = filepath.Join(runtime.GOROOT(), "test", dir)
-
 			for _, baseGoFile := range goFiles(dir) {
 				tests = append(tests, startTest(dir, baseGoFile))
 			}
@@ -596,7 +592,7 @@ func (t *test) run() {
 	// GOPHERJS: For now, only run with "run", "cmpout" actions, in "fixedbugs" dir.
 	switch action {
 	case "run", "cmpout":
-		if t.dir != "fixedbugs" {
+		if filepath.Clean(t.dir) != "fixedbugs" {
 			action = "skip"
 		}
 	case "rundircmpout", "compile", "compiledir", "build", "runoutput",

Original file line number	Diff line number	Diff line change
`@@ -217,10 +217,6 @@ func main() {`
`217`	`217`	`}`
`218`	`218`	`} else {`
`219`	`219`	`for _, dir := range dirs {`
`220`		`- // GOPHERJS.`
`221`		`- // TODO: Make this work so test filter doesn't break, etc.`
`222`		`- //dir = filepath.Join(runtime.GOROOT(), "test", dir)`
`223`		`-`
`224`	`220`	`for _, baseGoFile := range goFiles(dir) {`
`225`	`221`	`tests = append(tests, startTest(dir, baseGoFile))`
`226`	`222`	`}`
`@@ -596,7 +592,7 @@ func (t *test) run() {`
`596`	`592`	`// GOPHERJS: For now, only run with "run", "cmpout" actions, in "fixedbugs" dir.`
`597`	`593`	`switch action {`
`598`	`594`	`case "run", "cmpout":`
`599`		`- if t.dir != "fixedbugs" {`
	`595`	`+ if filepath.Clean(t.dir) != "fixedbugs" {`
`600`	`596`	`action = "skip"`
`601`	`597`	`}`
`602`	`598`	`case "rundircmpout", "compile", "compiledir", "build", "runoutput",`